[PATCH] D62700: [PGO] Handle cases of non-instrument BBs

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 14:55:48 PDT 2019


xur added a comment.

In D62700#1536841 <https://reviews.llvm.org/D62700#1536841>, @davidxl wrote:

> This can be handled this way:
>
>   BBInfo &SrcInfo = getBBInfo(SrcBB);    // BBInfo is the template type
>   BBInfo &DestInfo = getBBInfo(DestBB);
>   SrcInfo.addOutEdge(E.get());
>   DestInfo.addInEdge(E.get());
>   
>
> For base class BBInfo, addOutEdge, addInEdge will be empty, while it is defined for UseBBInfo class.
>
> By so doing, the code is more readable.


Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62700/new/

https://reviews.llvm.org/D62700





More information about the llvm-commits mailing list