[PATCH] D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 10 14:53:08 PDT 2019
compnerd added inline comments.
================
Comment at: llvm/test/ObjectYAML/MachO/virtual_section.yaml:85
+ reserved2: 0x00000000
+ reserved3: 0x00000000
+ - cmd: LC_BUILD_VERSION
----------------
I think that the `__TEXT,__eh_frame` is unnecessary for the test as is `__LD,__compact_unwind` and `___DATA,__common`. It would be nice to have the TLS and the large zero-filled section in the test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62991/new/
https://reviews.llvm.org/D62991
More information about the llvm-commits
mailing list