[PATCH] D63090: [objcopy] Error when --preserve-dates is specified with standard streams

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht accepted this revision.
rupprecht added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/invalid-preserve-dates.test:8
+# RUN: not llvm-strip --preserve-dates - %p/Inputs/alloc-symtab.o < %p/Inputs/alloc-symtab.o 2>&1 | FileCheck %s
+# RUN: not llvm-strip --preserve-dates %p/Inputs/alloc-symtab.o - %p/Inputs/alloc-symtab.o < %p/Inputs/alloc-symtab.o 2>&1 | FileCheck %s
+
----------------
abrachet wrote:
> These lines were getting very long. I tried to split it up with '\' but it didn't work. Is there another way to do this or is it fine to have very long lines?
You should be able to use `\`. Maybe you forgot to start the continuation line with `RUN:`? That's what was happening to me when I couldn't get it to work. See bad-output-format.test as an example.

There's no rule for short lines in tests, but when they get too long (>100 columns), I find it more readable to split them up around 80 columns.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63090/new/

https://reviews.llvm.org/D63090