[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:812
+#       llvm::PassPluginLibraryInfo ${entry_point}();
+add_custom_target(LLVM_PLUGINS)  # target used to hold global properties referencable from generator-expression
+function(register_llvm_extension llvm_extension entry_point)
----------------
Change this to `llvm-plugins` to match our convention and wrap it in `if (NOT TARGET...)` so it doesn't error if AddLLVM is included twice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61446/new/

https://reviews.llvm.org/D61446