[PATCH] D63083: [DebugInfo][Docs] Document that prologue/epilogue variable location changes are ignored

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 10:38:45 PDT 2019


bjope accepted this revision.
bjope added a comment.
This revision is now accepted and ready to land.

Looks good to me (matching my assumptions about why prolog/epilog is special).
Just a minor nit inline.



================
Comment at: docs/SourceLevelDebugging.rst:586
+ * The first operand can record the variable location as a register,
+   a frame index, an
    immediate, or the base address register if the original debug intrinsic
----------------
I guess the formatting was choosen to avoid unnecessary diffs.
I usually end up reading the .rst files as plain text more often than I read the docs using some browser etc. which makes this look weird.
nit: Not sure what the common practice is, but I don't mind if line breaks are updated for the full sentence/paragraph.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63083/new/

https://reviews.llvm.org/D63083





More information about the llvm-commits mailing list