[PATCH] D63013: [llvm-dwarfdump] Add -o to help text and remove --out-file from documentation

[James Henderson via Phabricator via llvm-commits]

jhenderson updated this revision to Diff 203849.
jhenderson retitled this revision from "[llvm-dwarfdump] Add --out-file to help text" to "[llvm-dwarfdump] Add -o to help text and remove --out-file from documentation".
jhenderson edited the summary of this revision.
jhenderson added a reviewer: aprantl.
jhenderson added a comment.

Remove --out-file from documentation and replace in help text with -o.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63013/new/

https://reviews.llvm.org/D63013

Files:
  docs/CommandGuide/llvm-dwarfdump.rst
  test/tools/llvm-dwarfdump/cmdline.test
  tools/llvm-dwarfdump/llvm-dwarfdump.cpp


Index: tools/llvm-dwarfdump/llvm-dwarfdump.cpp
===================================================================
--- tools/llvm-dwarfdump/llvm-dwarfdump.cpp
+++ tools/llvm-dwarfdump/llvm-dwarfdump.cpp
@@ -160,12 +160,11 @@
                 "available file, function, block and line table details."),
            value_desc("address"), cat(DwarfDumpCategory));
 static opt<std::string>
-    OutputFilename("out-file", cl::init("-"),
+    OutputFilename("o", cl::init("-"),
                    cl::desc("Redirect output to the specified file."),
-                   cl::value_desc("filename"));
-static alias OutputFilenameAlias("o", desc("Alias for -out-file."),
-                                 aliasopt(OutputFilename),
-                                 cat(DwarfDumpCategory));
+                   cl::value_desc("filename"), cat(DwarfDumpCategory));
+static alias OutputFilenameAlias("out-file", desc("Alias for -o."),
+                                 aliasopt(OutputFilename));
 static opt<bool>
     UseRegex("regex",
              desc("Treat any <pattern> strings as regular expressions when "
Index: test/tools/llvm-dwarfdump/cmdline.test
===================================================================
--- test/tools/llvm-dwarfdump/cmdline.test
+++ test/tools/llvm-dwarfdump/cmdline.test
@@ -1,5 +1,5 @@
-RUN: llvm-dwarfdump -h 2>&1 | FileCheck --check-prefix=HELP %s
-RUN: llvm-dwarfdump --help 2>&1 | FileCheck --check-prefix=HELP %s
+RUN: llvm-dwarfdump -h 2>&1 | FileCheck --check-prefix=HELP %s --implicit-check-not=out-file
+RUN: llvm-dwarfdump --help 2>&1 | FileCheck --check-prefix=HELP %s --implicit-check-not=out-file
 HELP: USAGE: llvm-dwarfdump{{[^ ]*}} [options] <input object files or .dSYM bundles>
 HELP-NOT: -reverse-iterate
 HELP: Color Options
@@ -13,6 +13,7 @@
 HELP: -ignore-case
 HELP: -lookup
 HELP: -name
+HELP: -o=<filename>
 HELP: -parent-recurse-depth=<N>
 HELP: -recurse-depth=<N>
 HELP: -regex
Index: docs/CommandGuide/llvm-dwarfdump.rst
===================================================================
--- docs/CommandGuide/llvm-dwarfdump.rst
+++ docs/CommandGuide/llvm-dwarfdump.rst
@@ -69,7 +69,7 @@
             Lookup <address> in the debug information and print out the file,
             function, block, and line table details.
 
-.. option:: -o <path>, --out-file=<path>
+.. option:: -o <path>
 
             Redirect output to a file specified by <path>.
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63013.203849.patch
Type: text/x-patch
Size: 2416 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190610/7f1d97be/attachment.bin>