[PATCH] D63077: [yaml2elf] - Check we are able to set custom sh_link for .symtab/.dynsym

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks good, aside from a few comment issues.



================
Comment at: test/tools/yaml2obj/dynsymtab-shlink.yaml:75
+
+## Check we can use section name as a Link value for .dynsym.
+
----------------
"use a section name..."


================
Comment at: test/tools/yaml2obj/symtab-shlink.yaml:72
+
+## Check we can use section name as a Link value for .symtab.
+
----------------
Ditto


================
Comment at: tools/yaml2obj/yaml2elf.cpp:408
+  if (RawSec && !RawSec->Link.empty()) {
+    // If Link field is explicitly defined in the document, we should use it.
+    unsigned Index;
----------------
If the Link ...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63077/new/

https://reviews.llvm.org/D63077