[PATCH] D62667: [ARM] Add the non-MVE instructions in Arm v8.1-M.

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham marked 3 inline comments as done.
simon_tatham added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5187
+
+def t2CSEL : CS<"csel"> {
+  let Inst{15-12} = 0b1000;
----------------
SjoerdMeijer wrote:
> Nit, I think this is more pleasant to read:
> 
>   def t2CSNEG : CS<"csneg", 0b1011>;
>   def t2CSINC : CS<"csinc", 0b1001>;
>   ...
> 
> perhaps an easy refactoring before you commit, but will leave that up to you.
Done, but due to a commit-time goof, it ended up in rL362955 instead.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62667/new/

https://reviews.llvm.org/D62667