[llvm] r362947 - [IRBuilder] Add CreateFNegFMF(...) to the IRBuilder
Cameron McInally via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 10 08:07:29 PDT 2019
Author: mcinally
Date: Mon Jun 10 08:07:29 2019
New Revision: 362947
URL: http://llvm.org/viewvc/llvm-project?rev=362947&view=rev
Log:
[IRBuilder] Add CreateFNegFMF(...) to the IRBuilder
Differential Revision: https://reviews.llvm.org/D62521
Modified:
llvm/trunk/include/llvm/IR/IRBuilder.h
llvm/trunk/unittests/IR/IRBuilderTest.cpp
Modified: llvm/trunk/include/llvm/IR/IRBuilder.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/IRBuilder.h?rev=362947&r1=362946&r2=362947&view=diff
==============================================================================
--- llvm/trunk/include/llvm/IR/IRBuilder.h (original)
+++ llvm/trunk/include/llvm/IR/IRBuilder.h Mon Jun 10 08:07:29 2019
@@ -1372,6 +1372,19 @@ public:
return Insert(BinaryOperator::CreateNot(V), Name);
}
+ /// Copy fast-math-flags from an instruction rather than using the builder's
+ /// default FMF.
+ Value *CreateFNegFMF(Value *V, Instruction *FMFSource,
+ const Twine &Name = "") {
+ if (auto *VC = dyn_cast<Constant>(V))
+ return Insert(Folder.CreateFNeg(VC), Name);
+ // TODO: This should return UnaryOperator::CreateFNeg(...) once we are
+ // confident that they are optimized sufficiently.
+ return Insert(setFPAttrs(BinaryOperator::CreateFNeg(V), nullptr,
+ FMFSource->getFastMathFlags()),
+ Name);
+ }
+
Value *CreateUnOp(Instruction::UnaryOps Opc,
Value *V, const Twine &Name = "",
MDNode *FPMathTag = nullptr) {
Modified: llvm/trunk/unittests/IR/IRBuilderTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/IR/IRBuilderTest.cpp?rev=362947&r1=362946&r2=362947&view=diff
==============================================================================
--- llvm/trunk/unittests/IR/IRBuilderTest.cpp (original)
+++ llvm/trunk/unittests/IR/IRBuilderTest.cpp Mon Jun 10 08:07:29 2019
@@ -206,12 +206,22 @@ TEST_F(IRBuilderTest, UnaryOperators) {
IRBuilder<NoFolder> Builder(BB);
Value *V = Builder.CreateLoad(GV->getValueType(), GV);
- // Test CreateUnOp
+ // Test CreateUnOp(X)
Value *U = Builder.CreateUnOp(Instruction::FNeg, V);
ASSERT_TRUE(isa<Instruction>(U));
ASSERT_TRUE(isa<FPMathOperator>(U));
ASSERT_TRUE(isa<UnaryOperator>(U));
ASSERT_FALSE(isa<BinaryOperator>(U));
+
+ // Test CreateFNegFMF(X)
+ Instruction *I = cast<Instruction>(V);
+ I->setHasNoSignedZeros(true);
+ I->setHasNoNaNs(true);
+ Value *VFMF = Builder.CreateFNegFMF(V, I);
+ Instruction *IFMF = cast<Instruction>(VFMF);
+ EXPECT_TRUE(IFMF->hasNoSignedZeros());
+ EXPECT_TRUE(IFMF->hasNoNaNs());
+ EXPECT_FALSE(IFMF->hasAllowReassoc());
}
TEST_F(IRBuilderTest, FastMathFlags) {
More information about the llvm-commits
mailing list