[PATCH] D62667: [ARM] Add the non-MVE instructions in Arm v8.1-M.

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 07:53:15 PDT 2019


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5187
+
+def t2CSEL : CS<"csel"> {
+  let Inst{15-12} = 0b1000;
----------------
Nit, I think this is more pleasant to read:

  def t2CSNEG : CS<"csneg", 0b1011>;
  def t2CSINC : CS<"csinc", 0b1001>;
  ...

perhaps an easy refactoring before you commit, but will leave that up to you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62667/new/

https://reviews.llvm.org/D62667





More information about the llvm-commits mailing list