[PATCH] D63024: [LLD] [Driver] Look for -m in response files as well

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: tools/lld/lld.cpp:145
+    if (isPETarget(ExpandedArgs))
+      return !mingw::link(ExpandedArgs);
     return !elf::link(Args, canExitEarly());
----------------
mstorsjo wrote:
> ruiu wrote:
> > Is it intentional that you call mingw::link with ExpandedArgs?
> The MinGW driver does no expansion of its own right now; I guess it would be better to do that there instead of passing the expanded args here - for consistency?
Yeah I think so. lld::mingw::link's contract should be the same as other link() functions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63024/new/

https://reviews.llvm.org/D63024