[PATCH] D63024: [LLD] [Driver] Look for -m in response files as well
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 10 04:49:24 PDT 2019
ruiu added inline comments.
================
Comment at: tools/lld/lld.cpp:141-143
+ SmallVector<const char *, 256> ExpandedArgs(Args.data(),
+ Args.data() + Args.size());
+ cl::ExpandResponseFiles(Saver, getDefaultQuotingStyle(), ExpandedArgs);
----------------
If you factor this piece of code to a new function, we can discard SmallVector, saving a small amount of memory.
================
Comment at: tools/lld/lld.cpp:145
+ if (isPETarget(ExpandedArgs))
+ return !mingw::link(ExpandedArgs);
return !elf::link(Args, canExitEarly());
----------------
Is it intentional that you call mingw::link with ExpandedArgs?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63024/new/
https://reviews.llvm.org/D63024
More information about the llvm-commits
mailing list