[PATCH] D62957: [yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection::Size optional

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 03:23:45 PDT 2019


jhenderson added a comment.

Looks like you missed some comments?



================
Comment at: test/tools/yaml2obj/section-size-content.yaml:105
+## than content size. In this case zeroes are added as padding
+## after content specified.
+
----------------
jhenderson wrote:
> after content specified -> after the specified content
This hasn't been done?


================
Comment at: test/tools/yaml2obj/strtab-implicit-sections-size-content.yaml:98
+## when size is greater than content size. In this case zeroes are
+## added as padding after content specified.
+
----------------
jhenderson wrote:
> Same as above.
Ditto


================
Comment at: test/tools/yaml2obj/symtab-implicit-sections-size-content.yaml:127
+## than content size. In this case zeroes are added as padding
+## after content specified.
+
----------------
jhenderson wrote:
> See above.
Ditto


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62957/new/

https://reviews.llvm.org/D62957





More information about the llvm-commits mailing list