[PATCH] D63024: [LLD] [Driver] Look for -flavor/-m in response files as well

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D63024#1535958 <https://reviews.llvm.org/D63024#1535958>, @ruiu wrote:

> I'm not particularly worried about the performance impact of doubly-expanding response files. If it is proved to be too slow, we need to do something, but until then I wouldn't optimize it.
>
> But at least we can expand response files only for GNU flavor. For COFF and WASM linkers, we don't have to expand them at this stage.


Ok, that makes sense. Then we can't handle the -flavor option in a response file, but there's no need for that either.

I'll update the patch that way. And I think I'll default the quoting style to the host platform native (like the ELF linker); I think that'll cause fewer issues down the line. (Currently the MinGW driver doesn't handle response files at all, but they fall through to the COFF linker.)


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63024/new/

https://reviews.llvm.org/D63024