[PATCH] D63042: [LLD][COFF] Fix missing MergeChunk::Instances cleanup in COFF::link()

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I was not trying to force you to use lld in some particular way. I was just trying to help you by suggesting one solution that might work for some use cases, and I didn't know that that wouldn't work for you. If it doesn't work for you, you can continue using lld as a library as you are already doing. We support that as well, and a bug like this should be fixed.

As to "clean up", I honestly don't think that lld's code is that bad. We use global variables, and there are pros and cons about that, but the design decision to use them was carefully made. This is not a quick dirty hack or something like that.

By the way thank you for fixing this bug. Feel free to send more patches if you find any bugs.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63042/new/

https://reviews.llvm.org/D63042