[PATCH] D63042: [LLD][COFF] Fix missing MergeChunk::Instances cleanup in COFF::link()

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 00:51:49 PDT 2019


ruiu added a comment.

In D63042#1535899 <https://reviews.llvm.org/D63042#1535899>, @ruiu wrote:

> LGTM
>
> Yes, I suspect that there are other globals that are not reset between multiple executions of this linker.
>
> As to how to invoke the linker as a separate process, I wonder if you can run your compiler as a new subprocess of the compiler. If you can do that,  you can invoke the linker with a special option to call lld::link immediately on process startup, which effectively transforms your compiler to a linker. This way, you still have to statically link lld to your compiler, but you can run the linker as a separate child process, which is generally preferred because bad thing like this or unknown bugs in the linker doesn't harm your compiler.


s/you can invoke the linker with a special option/you can invoke the compiler with a special option/


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63042/new/

https://reviews.llvm.org/D63042





More information about the llvm-commits mailing list