[PATCH] D62890: [PowerPC] Merge consecutive stores of vector elements before types are legalized
Kai Luo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 9 22:46:49 PDT 2019
lkail added a comment.
In D62890#1532667 <https://reviews.llvm.org/D62890#1532667>, @niravd wrote:
> This seems like it should be folded into the already existing checks. Do you know why NumStoresToMerge was not being before. I expect it's the requirement of a legal types in pre-legal merges or PPC's check for allowed misaligned accesses missing some cases. If it's the former I suspect we can disable the legality requirement prelegaltypes for non-truncated stores (replace TLI.isTypeLegal(ty) with isTypeLegal(ty)).
Thanks for responding, @niravd. I currently have no idea of why NumStoresToMerge was not being before. I might have a look at patches related to this portion of code. I notice that consecutive stores of vector elements was first introduced by https://reviews.llvm.org/rL224611 in which a legal type was a requirement already.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62890/new/
https://reviews.llvm.org/D62890
More information about the llvm-commits
mailing list