[PATCH] D63044: [LangRef] Clarify poison semantics

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 9 13:11:11 PDT 2019


jdoerfert added inline comments.


================
Comment at: llvm/docs/LangRef.rst:2160
+-  An :ref:`undef value <undefvalues>` in *any* address-space is
+   associated with no address.
 -  An integer constant other than zero or a pointer value returned from
----------------
IMHO this is great, regardless of the poison discussion. Thanks for adding it.


================
Comment at: llvm/docs/LangRef.rst:3276
+
+Additionally, undefined behavior occurs if a side effect depends on poison.
 
----------------
Now, side effects, what do we count and why do we have it explicitly.

Also, should we explicitly mention control flow or is it sufficiently covered by the "*depends*" definition above?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63044/new/

https://reviews.llvm.org/D63044





More information about the llvm-commits mailing list