[PATCH] D63058: [InlineCost] Fix bug 42084: return the first negative result

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 9 08:00:10 PDT 2019


lebedev.ri added a comment.

2 questions, since i've read through the diff:

1. will this pick the smallest cost, or the first negative cost?
2. is this missing some abstraction? maybe `InlineResult Result` should be some wrapper that should be assigned-to, that will internally only accept the new value if it's better than what it currently has,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63058/new/

https://reviews.llvm.org/D63058





More information about the llvm-commits mailing list