[PATCH] D63045: Do not derive no-recurse attribute if function does not have exact definition.
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 8 10:58:47 PDT 2019
jdoerfert added a comment.
In D63045#1535255 <https://reviews.llvm.org/D63045#1535255>, @vivekvpandya wrote:
> In D63045#1535246 <https://reviews.llvm.org/D63045#1535246>, @jdoerfert wrote:
>
> > LGTM. Though I hope to remove the FunctionAttr code soonish.
>
>
> If this code will be removed do we need to commit this?
We should.
> if yes then is my testing enough?
I think so.
> I have tested this change with check-all (where my build has all targets, clang project enabled)
Good.
> I am missing anything on testing?
No.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63045/new/
https://reviews.llvm.org/D63045
More information about the llvm-commits
mailing list