[PATCH] D61969: llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object
Jordan Rupprecht via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 7 14:48:56 PDT 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362847: [llvm-objdump] Fix Bugzilla ID 41862 to support checking addresses of… (authored by rupprecht, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61969?vs=203131&id=203628#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61969/new/
https://reviews.llvm.org/D61969
Files:
llvm/trunk/test/tools/llvm-objdump/X86/start-stop-address.test
llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
Index: llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
===================================================================
--- llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
+++ llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
@@ -1417,8 +1417,8 @@
}
static void disassembleObject(const ObjectFile *Obj, bool InlineRelocs) {
- if (StartAddress > StopAddress)
- error("Start address should be less than stop address");
+ if (StartAddress >= StopAddress)
+ error("start address should be less than stop address");
const Target *TheTarget = getTarget(Obj);
Index: llvm/trunk/test/tools/llvm-objdump/X86/start-stop-address.test
===================================================================
--- llvm/trunk/test/tools/llvm-objdump/X86/start-stop-address.test
+++ llvm/trunk/test/tools/llvm-objdump/X86/start-stop-address.test
@@ -68,4 +68,5 @@
// OUT-OF-RANGE-NOT: Disassembly
// RUN: not llvm-objdump -d %t.out --start-address=0x40 --stop-address=0x3f 2>&1 | FileCheck %s --check-prefix ERRMSG
-// ERRMSG: error: Start address should be less than stop address.
+// RUN: not llvm-objdump -d %t.out --start-address=0x40 --stop-address=0x40 2>&1 | FileCheck %s --check-prefix ERRMSG
+// ERRMSG: start address should be less than stop address.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61969.203628.patch
Type: text/x-patch
Size: 1261 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190607/e7315d99/attachment.bin>
More information about the llvm-commits
mailing list