[PATCH] D62963: [DAGCombine] GetNegatedExpression - constant float vector support (PR42105)

Fri Jun 7 12:22:28 PDT 2019

cameron.mcinally accepted this revision.
cameron.mcinally added a comment.
This revision is now accepted and ready to land.

LGTM, although I'm not fluent in AMDGPU assembly. You may want to wait a little while to see if an expert comes along.

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:913
+    if (ConstantFPSDNode *N0CFP =
+            isConstOrConstSplatFP(Op.getOperand(0), /*AllowUndefs*/ true))
       if (N0CFP->isZero())
----------------
Nit: I don't anticipate any regressions from this change, but this could be split-off to a separate patch -- if we're being pedantic.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62963/new/

https://reviews.llvm.org/D62963