[PATCH] D62705: [IR] Add UnaryOperator::CreateFNegFMF(...)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 11:38:25 PDT 2019


spatel added inline comments.


================
Comment at: llvm/include/llvm/IR/InstrTypes.h:168
+                                      const Twine &Name = "") {
+    return CreateWithCopiedFlags(Instruction::FNeg, Op, FMFSource);
+  }
----------------
cameron.mcinally wrote:
> spatel wrote:
> > Sorry, I missed this on 1st glance: we should be passing the "Name" parameter through here.
> Good catch. I copied that from BinaryOperator::CreateFNegFMF(...). I'll update both if there are no objections.
Yes, please fix both.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62705/new/

https://reviews.llvm.org/D62705





More information about the llvm-commits mailing list