[PATCH] D62607: LoopDistribute/LAA: Respect convergent

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:2017
+                         "would be needed with a convergent operation\n");
+    CanVecMem = false;
+    return;
----------------
kbarton wrote:
> Maybe I'm missing something here, but shouldn't this case (HasConvergentOp) go in the condition above (isDependencyCheckNeeded)?
> In other words, is it not possible that we do not need a runtime check and thus can still vectorize?
This is what I tried initially, but moved it down here. LoopDistribute has the strange property of partially ignoring the memory dependencies here, and picking out the ones it really cares about. The runtime checks here still need to be detected for that to work


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62607/new/

https://reviews.llvm.org/D62607