[PATCH] D61935: Fixes PPC64 Tbegin disassembling

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 10:19:31 PDT 2019


jsji added a comment.

I had a quick look, and the problem is that after the fix,
`TBEGIN` doesn't have any `outs` now, hence no valid `RC`, so we can't `EXTRACT_SUBREG` from this DAG.

We should `EXTRACT_SUBREG` from `CR0` directly, however,  we will still need `TBEGIN` before it to update `CR0`,
so this is not a single DAG any more.

So it looks like we can NOT use the simple `Pat<..>` to expand builtin `int_ppc_tbegin` any more,
we should try to expand it as `PPCCustomInserterPseudo`.

You should be able to fix it similar to `TCHECK_RET`.
Let me know if you want me to commandeer this Revision. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61935/new/

https://reviews.llvm.org/D61935





More information about the llvm-commits mailing list