[PATCH] D62532: [AIX] Implement function descriptor on SDAG
Xiangling Liao via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 7 08:47:36 PDT 2019
Xiangling_L marked 2 inline comments as done.
Xiangling_L added inline comments.
================
Comment at: llvm/trunk/include/llvm/MC/MCSymbolXCOFF.h:13
+#include "llvm/MC/MCSymbol.h"
+#include "llvm/IR/GlobalValue.h"
+
----------------
gribozavr wrote:
> gribozavr wrote:
> > llvm/IR/GlobalValue.h can't be included in MC, that creates a circular dependency between MC and IR libraries. This circular dependency is causing an issue for build system that enforce layering. Is there another way to implement this change?
> I committed a workaround in r362782, but it is only a workaround, and it would be nice to have a real fix.
Thanks for the workaround. We will discuss and see if there is a better way to implement this.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62532/new/
https://reviews.llvm.org/D62532
More information about the llvm-commits
mailing list