[PATCH] D62966: [ARM] Add fp16 addressing to isLegalT2AddressImmediate

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/test/Analysis/CostModel/ARM/gep.ll:329
+; CHECK-MVE-NEXT:  Cost Model: Found an estimated cost of 1 for instruction: %a256 = getelementptr inbounds half, half* %a, i32 256
+; CHECK-MVE-NEXT:  Cost Model: Found an estimated cost of 0 for instruction: %am255 = getelementptr inbounds half, half* %a, i32 -255
+; CHECK-MVE-NEXT:  Cost Model: Found an estimated cost of 1 for instruction: %am256 = getelementptr inbounds half, half* %a, i32 -256
----------------
samparker wrote:
> Could you add testing for around an offset of +/- 510?
These are gep offsets so all "number of units", not "bytes". Is that what you meant? It caught me out originally.

(Yes, this makes testing unaligned access harder, like an byte offset of 1, not 2)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62966/new/

https://reviews.llvm.org/D62966