[PATCH] D62967: [ARM] Add MVE addressing to isLegalT2AddressImmediate

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 05:03:38 PDT 2019


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:13305
+  if (VT.isVector()) {
+    if (Subtarget->hasMVEFloatOps()) {
+      switch (VT.getSimpleVT().getVectorElementType().SimpleTy) {
----------------
samparker wrote:
> I think it would be cleaner to exit early for floats without support, like we do currently at the start of the function. Then we can have a single switch statement here.
OK. yeah. I see what you mean. That sounds like a good idea.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62967/new/

https://reviews.llvm.org/D62967





More information about the llvm-commits mailing list