[PATCH] D62976: [LLD] [COFF] Add an lld specific option /includeoptional

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 04:25:48 PDT 2019


ruiu added a comment.

In D62976#1533960 <https://reviews.llvm.org/D62976#1533960>, @mstorsjo wrote:

> In D62976#1533841 <https://reviews.llvm.org/D62976#1533841>, @ruiu wrote:
>
> > I guess that my previous comment addresses the issue?
>
>
> Yes, probably - thanks!
>
> Since we fetch objects iteratively in the COFF linker, we probably need to wait until the normal link has converged, then fetch lazy objs for -u, and then keep iterating until it converges again?


Yeah, I guess so. Technically, fetching an object file can add a new archive to the input file set via a .drctive section which could in turn make other -u symbols can be resolved, so we need to iterate the whole process until it converges. That said, I don't think we have to cover that case though.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62976/new/

https://reviews.llvm.org/D62976





More information about the llvm-commits mailing list