[PATCH] D63003: [ELF] Don't emit dynamic relocations with weak undef in writable sections

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 04:20:38 PDT 2019


ruiu added inline comments.


================
Comment at: test/ELF/weak-undef-rw.s:10
+
+# CHECK: no relocations
 
----------------
MaskRay wrote:
> grimar wrote:
> > What is GNU linkers behavior in this case?
> GNU linkers don't emit dynamic relocations for executables, so this change seems to improves compatibility.
Hm, if this is the same as GNU linker, I believe it's a safe change in practice.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63003/new/

https://reviews.llvm.org/D63003





More information about the llvm-commits mailing list