[PATCH] D62940: [PPC32] Support TLS GD/LE/IE/LE relocation types and their relaxations

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

LGTM



================
Comment at: lld/trunk/ELF/Arch/PPC.cpp:56
+static uint32_t readFromHalf16(const uint8_t *Loc) {
+  return read32(Loc - (Config->EKind == ELF32BEKind ? 2 : 0));
+}
----------------
nit: it may be easier to read if you change this to

  if (Config->IsLE)
    return read32(Loc);
  else
    return read32(Loc - 2);



================
Comment at: lld/trunk/ELF/Arch/PPC.cpp:60
+static void writeFromHalf16(uint8_t *Loc, uint32_t Insn) {
+  write32(Loc - (Config->EKind == ELF32BEKind ? 2 : 0), Insn);
+}
----------------
Ditto


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62940/new/

https://reviews.llvm.org/D62940