[PATCH] D62364: llvm-objcopy: Implement --extract-partition and --extract-main-partition.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/Inputs/partitions.elf.test:5
+// RUN: llvm-mc %s -o %t.o -filetype=obj --triple=x86_64-unknown-linux
+// RUN: ld.lld %t.o -o %t --export-dynamic --gc-sections
+
----------------
pcc wrote:
> MaskRay wrote:
> > `ld.lld` can be used in a llvm-objcopy test. This may have to be moved to lld/test/ELF/
> (assuming you meant *can't* be used)
> 
> Yes, that's correct. That's why I'm checking in a binary (partitions.elf) to be used during this test. The purpose of this file is to document how I generated partitions.elf.
Sorry I didn't notice this file is in the `Inputs/` directory so these lines do not run.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62364/new/

https://reviews.llvm.org/D62364