[PATCH] D62710: [X86] Disable f32->f64 extload when sse2 is enabled

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 6 22:26:25 PDT 2019


craig.topper added a comment.

Removing the "(fpextend (loadf32 addr:$src))" pattern without this patch doesn't fail any tests. Not sure if the peephole pass kicks in to hide it.
Removing the (extloadf32 addr:$src) without this patch fails isel since the extload won't match

With the change to X86ISelLowering.cpp from this patch applied and the (fpextend (loadf32 addr:$src)) removed, we fail to fold some loads in sse2-intrinsics-upgrade-x86.ll because it explicitly disables the peephole pass. brcond.ll. If I also remove the load folding table entries sse_partial_update.ll also fails. As well as stack folding and fast isel but those are to be expected since they depend exclusively on the table.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62710/new/

https://reviews.llvm.org/D62710





More information about the llvm-commits mailing list