[PATCH] D62476: [clangd] Support offsets for parameters in signatureHelp

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added inline comments.


================
Comment at: clang-tools-extra/trunk/clangd/CodeComplete.cpp:925
+    // FIXME: this should only be set on CK_CurrentParameter.
+    Signal.ContainsActiveParameter = true;
+  }
----------------
ilya-biryukov wrote:
> ilya-biryukov wrote:
> > uabelho wrote:
> > > Hi!
> > > 
> > > gcc (7.4) warns on this code:
> > > 
> > > ```
> > > error: parameter 'Signal' set but not used [-Werror=unused-but-set-parameter]
> > >                               SignatureQualitySignals Signal) const {
> > >                                                       ^~~~~~
> > > ```
> > > Should Signal be a reference? Or is it specifically not a reference right now due to the FIXME?
> > Should be a reference, thanks for bringing that up! I'll send a fix.
> Removed this flag altogether in r362686, it is not used and has we have no tests for it.
Thanks!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62476/new/

https://reviews.llvm.org/D62476