[PATCH] D62718: [llvm-objcopy] Change handling of output file permissions

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht marked an inline comment as done.
rupprecht added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/Buffer.h:50
 
-  explicit FileBuffer(StringRef FileName) : Buffer(FileName) {}
+  explicit FileBuffer(StringRef FileName, unsigned Flags = 0)
+      : Buffer(FileName), Flags(Flags) {}
----------------
abrachet wrote:
> rupprecht wrote:
> > "explicit" can be removed now that this is two-args (and there's no implicit-conversion risk)
> I quickly checked if this was still the case because of the default arg, explicit does still protect here. Can be seen here if curious https://godbolt.org/z/nAlqDq
Yep! Of course, I forgot about default args affecting that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62718/new/

https://reviews.llvm.org/D62718