[PATCH] D62974: Add cdb test for global constants

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 6 12:47:19 PDT 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

This should be running here now:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc
I'd suggest checking if it's green tomorrow.



================
Comment at: debuginfo-tests/win_cdb/global-constant.cpp:27-28
+  // CHECK: TestEnum ENUM_NEG (0n-2147000000)
+  // DEBUGGER: ?? ENUM_POS
+  // CHECK: Couldn't resolve error at 'ENUM_POS'
+  // DEBUGGER: q
----------------
Please add a comment indicating why this is intended behavior. ENUM_POS is unused, so it never ends up in the globals stream, so we expect this to fail.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62974/new/

https://reviews.llvm.org/D62974





More information about the llvm-commits mailing list