[PATCH] D62939: Strengthen LFTR's ability to replace IVs

[Philip Reames via Phabricator via llvm-commits]

reames updated this revision to Diff 203416.
reames added a comment.

Remove the two cases Nikita noted.

Nikita, do you see any other problems with this?  If it looks okay conceptually, my next step will be to write a bunch of tests.  I'd like to check this in to IndVarSimplify, and then in a separate reviewed NFC change move it into ValueTracking and common with the existing version as much as possible.  Does that seem like a reasonable plan?

I'm not entirely comfortable trying to test this exclusively through LFTR.  Any ideas on how to better expose it?  (I'm not saying I think testing through LFTR isn't a reasonable starting point to get it committed, just that long term, I think the final code in ValueTracking will be too important to only test through one transform.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62939/new/

https://reviews.llvm.org/D62939

Files:
  lib/Transforms/Scalar/IndVarSimplify.cpp
  test/Transforms/IndVarSimplify/2011-11-01-lftrptr.ll
  test/Transforms/IndVarSimplify/lftr-reuse.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62939.203416.patch
Type: text/x-patch
Size: 11206 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190606/7906ed37/attachment.bin>