[PATCH] D62532: [AIX] Implement function descriptor on SDAG

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/CodeGen/LLVMTargetMachine.cpp:205
+    if (this->getTargetTriple().isOSAIX()) {
+      // On AIX we might manifest MCSymbols during SDAG lowering. For MIR
+      // testing to be meaningful we need to ensure that the symbols created
----------------
Add a comma after "AIX".


================
Comment at: llvm/lib/CodeGen/LLVMTargetMachine.cpp:206
+      // On AIX we might manifest MCSymbols during SDAG lowering. For MIR
+      // testing to be meaningful we need to ensure that the symbols created
+      // are MCSymboLXCOFF variants, which requires that
----------------
Add a comma after "meaningful".


================
Comment at: llvm/lib/CodeGen/LLVMTargetMachine.cpp:207
+      // testing to be meaningful we need to ensure that the symbols created
+      // are MCSymboLXCOFF variants, which requires that
+      // TargetLoweringObjectFile has been initialized.
----------------
s/MCSymboLXCOFF/MCSymbolXCOFF/;


================
Comment at: llvm/lib/CodeGen/LLVMTargetMachine.cpp:208
+      // are MCSymboLXCOFF variants, which requires that
+      // TargetLoweringObjectFile has been initialized.
+      MCContext &Ctx = MMI->getContext();
----------------
s/TargetLoweringObjectFile/the TargetLoweringObjectFile instance/;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62532/new/

https://reviews.llvm.org/D62532