[PATCH] D62532: [AIX] Implement function descriptor on SDAG

[Sean Fertile via Phabricator via llvm-commits]

sfertile accepted this revision.
sfertile added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/CodeGen/LLVMTargetMachine.cpp:205
+    if (this->getTargetTriple().isOSAIX()) {
+      // On AIX , we replace GlobalAddressSDNode with MCSymbolSDNode in SDAG for
+      // the callee of a direct function call. To create the MCSymbolXCOFF
----------------
hubert.reinterpretcast wrote:
> Sorry for missing this earlier. Please remove the space before the comma.
I would suggest slightly rewording thjis comment along the lines of:

```On AIX we might manifest MCSymbols during SDAG lowering. For mir testing to be meaningful we need to ensure that the symbols created are MCSymboLXCOFF variants, which requires that TargetLoweringObjectFile has been initialized.```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62532/new/

https://reviews.llvm.org/D62532