[PATCH] D62959: TailDuplicator: Remove no-op analyzeBranch call
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 6 08:15:03 PDT 2019
arsenm created this revision.
arsenm added reviewers: iteratee, sanjoy.
Herald added a subscriber: wdng.
This could fail, which looked concerning. However nothing was actually
using the results of this. I assume this was intended to use the
anti-feature of analyzeBranch of removing instructions, but wasn't
actually calling it with AllowModify = true.
Fixes bug 42162.
https://reviews.llvm.org/D62959
Files:
lib/CodeGen/TailDuplicator.cpp
Index: lib/CodeGen/TailDuplicator.cpp
===================================================================
--- lib/CodeGen/TailDuplicator.cpp
+++ lib/CodeGen/TailDuplicator.cpp
@@ -856,11 +856,6 @@
}
appendCopies(PredBB, CopyInfos, Copies);
- // Simplify
- MachineBasicBlock *PredTBB = nullptr, *PredFBB = nullptr;
- SmallVector<MachineOperand, 4> PredCond;
- TII->analyzeBranch(*PredBB, PredTBB, PredFBB, PredCond);
-
NumTailDupAdded += TailBB->size() - 1; // subtract one for removed branch
// Update the CFG.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62959.203371.patch
Type: text/x-patch
Size: 547 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190606/e2c8491f/attachment.bin>
More information about the llvm-commits
mailing list