[PATCH] D62541: Adding a function for setting coverage output file.
Max Moroz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 6 07:49:05 PDT 2019
Dor1s added a comment.
LGTM (was OOO), thanks a lot David for Sajjad for multiple iterations here. One question: was the test landed? I see it in the latest patchset (https://reviews.llvm.org/D62541?id=203034), but not in the code that was committed.
================
Comment at: compiler-rt/trunk/lib/profile/InstrProfilingFile.c:270
+static FILE *GetFileObject(const char *OutputName) {
+ FILE *File;
----------------
nit: looks like this should start with a lowercase, `GetFileObject` -> `getFileObject`
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62541/new/
https://reviews.llvm.org/D62541
More information about the llvm-commits
mailing list