[PATCH] D61866: [RISCV] Rename RISCVELFStreamer.{cpp,h} to RISCVTargetELFStreamer.{cpp,h}

Thu Jun 6 05:45:57 PDT 2019

jrtc27 added a comment.

In D61866#1532288 <https://reviews.llvm.org/D61866#1532288>, @asb wrote:

> I think this is less confusing, but there's more to be gained by having a similar naming scheme to the other backends which right now all use FooELFStreamer.{cpp,h}.
>
> I you feel strongly about this change, I'd consider making it for all in-tree backends.

FooELFStreamer.cpp is not a target streamer but an MCELFStreamer. Generally the target streamers live in FooTargetStreamer.cpp. For example, MipsELFStreamer vs MipsTargetELFStreamer. At least that's my understanding, and this patch was motivated by wanting a RISCV-specific MCELFStreamer in our fork, which by that convention should be in RISCVELFStreamer.cpp.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61866/new/

https://reviews.llvm.org/D61866