[PATCH] D62912: [yaml2elf] - Refactoring followup for D62809

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: tools/yaml2obj/yaml2elf.cpp:313
+      continue;
+
+    SHeader.sh_name = DotShStrtab.getOffset(SecName);
----------------
It's not immediately obvious from reading the code that Sec can only be nullptr if it is an implicit section. I wonder if it would be clearer to the future reader to add an explicit assert somewhere around here to document that point?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62912/new/

https://reviews.llvm.org/D62912