[PATCH] D62464: [PPC32] Improve 32-bit PowerPC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 23:12:51 PDT 2019


MaskRay marked 5 inline comments as done.
MaskRay added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:2313
+    // Then write PLTresolve.
+    Target->writePltHeader(Buf + 4 * N);
+    return;
----------------
ruiu wrote:
> Hmm, so we don't call writePlt() if a target is PPC32?
On PPC32, how PLT works is different from targets (it is still similar to PPC64). I've added more comments in PPC::writePltHeader.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62464/new/

https://reviews.llvm.org/D62464





More information about the llvm-commits mailing list