[PATCH] D62718: [llvm-objcopy] Change output file permissions to be the same as the input file
Alex Brachet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 5 22:59:47 PDT 2019
abrachet marked 8 inline comments as done.
abrachet added inline comments.
================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:214
+ mode_t Mask = ::umask(0);
+ (void)::umask(Mask);
+#else
----------------
Removing the space between (void) and ::umask was clang-formats doing, but I figured I would keep it and ask here. I couldn't find references to calling functions in the global namespace, or unused results in the style guide.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62718/new/
https://reviews.llvm.org/D62718
More information about the llvm-commits
mailing list