[PATCH] D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class.

[Don Hinton via Phabricator via llvm-commits]

hintonda marked an inline comment as done.
hintonda added inline comments.


================
Comment at: llvm/include/llvm/Support/CommandLine.h:290
+  // Return the set of OptionCategories that this Option belongs to.
+  SmallPtrSet<OptionCategory *, 16> getCategories() const;
+
----------------
MaskRay wrote:
> 16. Does it have to be so large?
No, it should probably be 1 or 2, and getSubCommands should probably be 1.  

Thanks for pointing this out. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62105/new/

https://reviews.llvm.org/D62105