[PATCH] D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer

Seiya Nuta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 17:43:59 PDT 2019


seiya added a comment.

In D62652#1530262 <https://reviews.llvm.org/D62652#1530262>, @alexshap wrote:

> so in general this looks very promising to me, 
>  however test coverage needs improvements imo,  though given that at the moment we don't expose any non-trivial options here, we can add more tests incrementally. Btw - for DYSYMTAB, SYMTAB - is it possible to add YAML-based tests ? or yaml2obj's support is not sufficient for this ?
>
> I'd also wait for @jhenderson and/or @rupprecht to take a look at this code as well.


It seems that yaml2obj supports DYSYMTAB and SYMTAB. I'll add YAML-based tests in another patch which implements symbol table rebuilding.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62652/new/

https://reviews.llvm.org/D62652





More information about the llvm-commits mailing list