[PATCH] D62350: ELF: Create synthetic sections for loadable partitions.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lld/test/ELF/partition-synthetic-sections.s:17
+
+// FIXME: llvm-objcopy does not preserve padding so for now we check the combined output file.
+// RUN: od -Ax -x %t | FileCheck %s -check-prefix=FILL
----------------
grimar wrote:
> Was issue about that reported? We have a good practice in LLVM tools to add an URL of the issue
> for each TODO in the test. That helps to cleanup such things a lot.
I looked into this a bit more and filed pr42145 and linked it here. Unfortunately fixing this isn't as simple as I first thought.


================
Comment at: lld/test/ELF/partition-synthetic-sections.s:23
+// CHECK: Section Headers:
+// CHECK: [ 1] .dynsym           DYNSYM          {{0*}}[[DYNSYM_ADDR:[^ ]*]]
+// CHECK-NEXT: .gnu.version      VERSYM          {{0*}}[[VERSYM_ADDR:[^ ]*]]
----------------
grimar wrote:
> You do not need `[ 1]` I think.
I was using it to make sure that there were no section headers before `.dynsym`. But I've switched to using `CHECK-NEXT` here like I was doing elsewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62350/new/

https://reviews.llvm.org/D62350