[PATCH] D62532: [AIX] Implement function descriptor on SDAG

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 15:33:45 PDT 2019


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/test_call_aix.ll:1
-; RUN: llc -mtriple powerpc-ibm-aix-xcoff -stop-after=machine-cp < %s | \
+; RUN: llc -mtriple powerpc-ibm-aix-xcoff -stop-after=machine-cp -init-MC < %s | \
 ; RUN: FileCheck --check-prefix=32BIT %s
----------------
Xiangling_L wrote:
> hubert.reinterpretcast wrote:
> > The `-init-MC` is no longer needed now; right?
> You are right. And I am wondering do we still wanna create this option for other platforms? or do we wanna make some changes to do target object file lowering for AIX only?
I spoke with @sfertile today, and my understanding is that we don't want to add the option if we will just always perform the initialization on AIX (in which case, we don't need the `willInitMCObjectFile` function either).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62532/new/

https://reviews.llvm.org/D62532





More information about the llvm-commits mailing list