[PATCH] D55506: [RFC v2] Allow target to handle STRICT floating-point nodes

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 15:14:25 PDT 2019


uweigand marked 2 inline comments as done.
uweigand added a comment.

In D55506#1529951 <https://reviews.llvm.org/D55506#1529951>, @andrew.w.kaylor wrote:

> OK. I'm convinced. This should let us get a correct solution in place, and as you say we can add on something to handle rounding modes later if needed.
>
> You should probably address Kit's minor comments, but otherwise I'd be very happy to see this committed.


Thanks for the review, Andrew!

I've updated the patch to address Kit's comments, and handle recent mainline changes, in particular the new STRICT_FP_ROUND and STRICT_FP_EXTEND nodes.  I'll be committing this version shortly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55506/new/

https://reviews.llvm.org/D55506





More information about the llvm-commits mailing list